]> git.openfabrics.org - ~emulex/infiniband.git/commitdiff
drm/ast: Remove unecessary NULL check in gem_free
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Sat, 5 Apr 2014 08:11:16 +0000 (10:11 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 22 Apr 2014 13:39:10 +0000 (15:39 +0200)
The ->gem_free_object never gets called with a NULL pointer, the check
is redundant. Also checking after the upcast allows compilers to elide
it anyway.

Spotted by coverity.

v2: Fix patch subject.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/ast/ast_main.c

index 38941a6563123141a8ebded9d54600c2bbe8acf3..01bf9e730acf6087d499ed5fb1ade94cd5763124 100644 (file)
@@ -418,8 +418,6 @@ void ast_gem_free_object(struct drm_gem_object *obj)
 {
        struct ast_bo *ast_bo = gem_to_ast_bo(obj);
 
-       if (!ast_bo)
-               return;
        ast_bo_unref(&ast_bo);
 }