]> git.openfabrics.org - ~emulex/infiniband.git/commitdiff
usb: gadget: amd5536udc: let udc-core manage gadget->dev
authorFelipe Balbi <balbi@ti.com>
Thu, 24 Jan 2013 13:10:10 +0000 (15:10 +0200)
committerFelipe Balbi <balbi@ti.com>
Mon, 18 Mar 2013 09:16:41 +0000 (11:16 +0200)
By simply setting a flag, we drop some boilerplate
code.

Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/amd5536udc.c

index 75973f33a4c80590ab6f8a012f9a1dec58c7ccbe..eee01ea70f8c13cd4e02a094612861ba9cf9818f 100644 (file)
@@ -3080,7 +3080,6 @@ static void udc_pci_remove(struct pci_dev *pdev)
        if (dev->active)
                pci_disable_device(pdev);
 
-       device_unregister(&dev->gadget.dev);
        pci_set_drvdata(pdev, NULL);
 
        udc_remove(dev);
@@ -3276,6 +3275,7 @@ static int udc_probe(struct udc *dev)
        dev->gadget.dev.release = gadget_release;
        dev->gadget.name = name;
        dev->gadget.max_speed = USB_SPEED_HIGH;
+       dev->gadget.register_my_device = true;
 
        /* init registers, interrupts, ... */
        startup_registers(dev);
@@ -3301,13 +3301,6 @@ static int udc_probe(struct udc *dev)
        if (retval)
                goto finished;
 
-       retval = device_register(&dev->gadget.dev);
-       if (retval) {
-               usb_del_gadget_udc(&dev->gadget);
-               put_device(&dev->gadget.dev);
-               goto finished;
-       }
-
        /* timer init */
        init_timer(&udc_timer);
        udc_timer.function = udc_timer_function;