]> git.openfabrics.org - ~emulex/infiniband.git/commitdiff
ethernet: cleanup eth_type_trans
authorstephen hemminger <stephen@networkplumber.org>
Sat, 28 Sep 2013 00:19:41 +0000 (17:19 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 1 Oct 2013 04:52:52 +0000 (21:52 -0700)
Remove old legacy comment and weird if condition.
The comment has outlived it's stay and is throwback to some
early net code (before my time). Maybe Dave remembers what it meant.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ethernet/eth.c

index 9bd3c31c30e5f6f0cf6c9195586cd26787b539bd..f777e17d28c8772572ed5cbf536d25e35558bad4 100644 (file)
@@ -169,20 +169,9 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
                else
                        skb->pkt_type = PACKET_MULTICAST;
        }
-
-       /*
-        *      This ALLMULTI check should be redundant by 1.4
-        *      so don't forget to remove it.
-        *
-        *      Seems, you forgot to remove it. All silly devices
-        *      seems to set IFF_PROMISC.
-        */
-
-       else if (1 /*dev->flags&IFF_PROMISC */) {
-               if (unlikely(!ether_addr_equal_64bits(eth->h_dest,
-                                                     dev->dev_addr)))
-                       skb->pkt_type = PACKET_OTHERHOST;
-       }
+       else if (unlikely(!ether_addr_equal_64bits(eth->h_dest,
+                                                  dev->dev_addr)))
+               skb->pkt_type = PACKET_OTHERHOST;
 
        /*
         * Some variants of DSA tagging don't have an ethertype field