common: cleanup warnings in common code base

Signed-off-by: Arlin Davis <arlin.r.davis@intel.com>

diff --git a/dapl/common/dapl_cno_util.c b/dapl/common/dapl_cno_util.c
index cad97472545a506f50fbe251621a763c6be88751..75fdcc92e888cbd0a68832c6ddd4cca6c56c9efc 100755 (executable)
--- a/dapl/common/dapl_cno_util.c
+++ b/dapl/common/dapl_cno_util.c
@@ -147,10 +147,6 @@ void dapl_cno_dealloc(IN DAPL_CNO * cno_ptr)
  */
 void dapl_internal_cno_trigger(IN DAPL_CNO * cno_ptr, IN DAPL_EVD * evd_ptr)
 {
-       DAT_RETURN dat_status;
-
-       dat_status = DAT_SUCCESS;
-
        dapl_os_assert(cno_ptr->header.magic == DAPL_MAGIC_CNO);
        /* The spec allows NULL EVDs. kDAPL doesn't have CNOs, they
         * are strictly used behind the scenes

diff --git a/dapl/common/dapl_hash.c b/dapl/common/dapl_hash.c
index 0811d7c8796e3cf5c538a85ed2e09691e6448772..b9679c3c39f4a041fb65bed72a52cd08080f2f09 100644 (file)
--- a/dapl/common/dapl_hash.c
+++ b/dapl/common/dapl_hash.c
@@ -363,7 +363,7 @@ dapls_hash_create(IN DAT_COUNT table_size, OUT DAPL_HASH_TABLE ** pp_table)
        *pp_table = p_table;
 
       bail:
-       return DAT_SUCCESS;
+       return dat_status;
 }
 
 /*

diff --git a/dapl/common/dapl_rmr_free.c b/dapl/common/dapl_rmr_free.c
index d3abecb82b2e35d35d50831ec3002e7771b7e835..5a95eb0df02379afe0c38a0fad060c2e64dc68df 100644 (file)
--- a/dapl/common/dapl_rmr_free.c
+++ b/dapl/common/dapl_rmr_free.c
@@ -56,7 +56,6 @@
 DAT_RETURN DAT_API dapl_rmr_free(IN DAT_RMR_HANDLE rmr_handle)
 {
        DAPL_RMR *rmr;
-       DAPL_PZ *pz;
        DAT_RETURN dat_status;
 
        dat_status = DAT_SUCCESS;
@@ -68,8 +67,7 @@ DAT_RETURN DAT_API dapl_rmr_free(IN DAT_RMR_HANDLE rmr_handle)
        }
 
        rmr = (DAPL_RMR *) rmr_handle;
-       pz = (DAPL_PZ *) rmr->param.pz_handle;
-       DAPL_CNTR(pz->header.owner_ia, DCNT_IA_RMR_FREE);
+       DAPL_CNTR(rmr->pz->header.owner_ia, DCNT_IA_RMR_FREE);
 
        /*
         * If the user did not perform an unbind op, release

diff --git a/dapl/common/dapl_srq_set_lw.c b/dapl/common/dapl_srq_set_lw.c
index 8202e4f84877ecde2e6e482a4b1c5e8e0d64ddab..22dd294b669865f0d5fba798f717eb44f43ad749 100644 (file)
--- a/dapl/common/dapl_srq_set_lw.c
+++ b/dapl/common/dapl_srq_set_lw.c
@@ -66,7 +66,6 @@
 DAT_RETURN DAT_API
 dapl_srq_set_lw(IN DAT_SRQ_HANDLE srq_handle, IN DAT_COUNT low_watermark)
 {
-       DAPL_SRQ *srq_ptr;
        DAT_RETURN dat_status;
 
        dat_status = DAT_SUCCESS;
@@ -80,8 +79,6 @@ dapl_srq_set_lw(IN DAT_SRQ_HANDLE srq_handle, IN DAT_COUNT low_watermark)
                goto bail;
        }
 
-       srq_ptr = (DAPL_SRQ *) srq_handle;
-
        dat_status = DAT_ERROR(DAT_NOT_IMPLEMENTED, DAT_NO_SUBTYPE);
 
       bail: