]> git.openfabrics.org - ~emulex/infiniband.git/commitdiff
xfs: fix misspelled S_IS...()
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 26 Jul 2011 00:54:24 +0000 (20:54 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 26 Jul 2011 19:05:30 +0000 (15:05 -0400)
mode_t is not a bitmap...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/xfs/linux-2.6/xfs_ioctl.c
fs/xfs/xfs_filestream.c

index 14fc00e32f6b925990faa5b81cb0194cf1d6aeea..f7ce7debe14c48a55f0003454bc43fa678961ca0 100644 (file)
@@ -265,7 +265,7 @@ xfs_open_by_handle(
                return PTR_ERR(filp);
        }
 
-       if (inode->i_mode & S_IFREG) {
+       if (S_ISREG(inode->i_mode)) {
                filp->f_flags |= O_NOATIME;
                filp->f_mode |= FMODE_NOCMTIME;
        }
index 87fceceee2dbea4b7b857705d881775cb61f99d1..3ff3d9e23ded3427194345d281e665a6704e64ce 100644 (file)
@@ -345,8 +345,8 @@ _xfs_filestream_update_ag(
         * directory and pip is NULL.
         */
        ASSERT(ip && ((S_ISREG(ip->i_d.di_mode) && pip &&
-                      (pip->i_d.di_mode & S_IFDIR)) ||
-                     ((ip->i_d.di_mode & S_IFDIR) && !pip)));
+                      S_ISDIR(pip->i_d.di_mode)) ||
+                     (S_ISDIR(ip->i_d.di_mode) && !pip)));
 
        mp = ip->i_mount;
        cache = mp->m_filestream;
@@ -537,7 +537,7 @@ xfs_filestream_lookup_ag(
        xfs_agnumber_t  ag;
        int             ref;
 
-       if (!(ip->i_d.di_mode & (S_IFREG | S_IFDIR))) {
+       if (!S_ISREG(ip->i_d.di_mode) && !S_ISDIR(ip->i_d.di_mode)) {
                ASSERT(0);
                return NULLAGNUMBER;
        }
@@ -579,9 +579,9 @@ xfs_filestream_associate(
        xfs_agnumber_t  ag, rotorstep, startag;
        int             err = 0;
 
-       ASSERT(pip->i_d.di_mode & S_IFDIR);
-       ASSERT(ip->i_d.di_mode & S_IFREG);
-       if (!(pip->i_d.di_mode & S_IFDIR) || !(ip->i_d.di_mode & S_IFREG))
+       ASSERT(S_ISDIR(pip->i_d.di_mode));
+       ASSERT(S_ISREG(ip->i_d.di_mode));
+       if (!S_ISDIR(pip->i_d.di_mode) || !S_ISREG(ip->i_d.di_mode))
                return -EINVAL;
 
        mp = pip->i_mount;