]> git.openfabrics.org - ~shefty/rdma-dev.git/commit
[media] mb86a20s: don't use state before initializing it
authorMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 23 Jan 2013 15:22:22 +0000 (13:22 -0200)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 23 Jan 2013 15:22:22 +0000 (13:22 -0200)
commitf167e302c6a1321ae9f4d3a24a6e5bac90a5c79d
treee593caf82564aee3aef76127ae861dacf6ac1196
parentf66d81b54dac26d4e601d4d7faca53f3bdc98427
[media] mb86a20s: don't use state before initializing it

As reported by Feng's kbuild test:
From: kbuild test robot <fengguang.wu@intel.com>
Subject: drivers/media/dvb-frontends/mb86a20s.c:706 mb86a20s_attach() error: potential null dereference 'state'.  (kzalloc returns null)
Date: Wed, 23 Jan 2013 19:30:43 +0800

commit: f66d81b54dac26d4e601d4d7faca53f3bdc98427 [media] mb86a20s: convert it to use dev_info/dev_err/dev_dbg

drivers/media/dvb-frontends/mb86a20s.c:706 mb86a20s_attach() error: potential null dereference 'state'.  (kzalloc returns null)
drivers/media/dvb-frontends/mb86a20s.c:706 mb86a20s_attach() error: we previously assumed 'state' could be null (see line 705)

As, at mb86a20s_attach(), we have an i2c pointer, use it for all printk
messages there, instead of state->i2c.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb-frontends/mb86a20s.c