]> git.openfabrics.org - ~emulex/infiniband.git/commit
cpupower tools: Fix warning and a bug with the cpu package count
authorPalmer Cox <p@lmercox.com>
Tue, 27 Nov 2012 12:17:47 +0000 (13:17 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 27 Nov 2012 22:07:19 +0000 (23:07 +0100)
commitea1021ffa65a81da3d393fcbd7509d6e40d4d325
tree65af69a0511ce4cc8d1f3a75c3a45cd4f6d823ff
parent35a169737cdf9155e890d60eae2b8fffc16d16ba
cpupower tools: Fix warning and a bug with the cpu package count

The pkgs member of cpupower_topology is being used as the number of
cpu packages. As the comment in get_cpu_topology notes, the package ids
are not guaranteed to be contiguous. So, simply setting pkgs to the value
of the highest physical_package_id doesn't actually provide a count of
the number of cpu packages. Instead, calculate pkgs by setting it to
the number of distinct physical_packge_id values which is pretty easy
to do after the core_info structs are sorted. Calculating pkgs this
way also has the nice benefit of getting rid of a sign comparison warning
that GCC 4.6 was reporting.

Signed-off-by: Palmer Cox <p@lmercox.com>
Signed-off-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
tools/power/cpupower/utils/helpers/topology.c