]> git.openfabrics.org - ~shefty/rdma-dev.git/commit
e1000e: potentially incorrect return for e1000_set_d3_lplu_state_ich8lan
authorBruce Allan <bruce.w.allan@intel.com>
Wed, 8 Feb 2012 02:55:14 +0000 (02:55 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Mon, 13 Feb 2012 21:15:03 +0000 (13:15 -0800)
commitd7eb33840bee3c8de3f64f3861350bcfac3eaf82
treec418fa4cf987a6c7175d4917103f1c523e0eca21
parent826072555b0dceac44a6e69a0c5be137e829c9d4
e1000e: potentially incorrect return for e1000_set_d3_lplu_state_ich8lan

In the unlikely event that e1e_wphy() returns an error, the returned error
code is not propogated to the caller of e1000_set_d3_lplu_state_ich8lan().
With this change, there is a rare possibility that ret_val might not get
set so it must be initialized.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/e1000e/ich8lan.c