]> git.openfabrics.org - ~emulex/infiniband.git/commit
net: sctp: bug-fixing: retran_path not set properly after transports recovering (v3)
authorChang Xiangzhong <changxiangzhong@gmail.com>
Wed, 13 Nov 2013 23:58:26 +0000 (00:58 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 14 Nov 2013 21:35:09 +0000 (16:35 -0500)
commitd30a58ba2ef5092f10985d357d22acab232b6dcc
treed77f00f64662b1c41bceda5083c123b55650e11e
parentdccf76ca6b626c0c4a4e09bb221adee3270ab0ef
net: sctp: bug-fixing: retran_path not set properly after transports recovering (v3)

When a transport recovers due to the new coming sack, SCTP should
iterate all of its transport_list to locate the __two__ most recently used
transport and set to active_path and retran_path respectively. The exising
code does not find the two properly - In case of the following list:

[most-recent] -> [2nd-most-recent] -> ...

Both active_path and retran_path would be set to the 1st element.

The bug happens when:
1) multi-homing
2) failure/partial_failure transport recovers
Both active_path and retran_path would be set to the same most-recent one, in
other words, retran_path would not take its role - an end user might not even
notice this issue.

Signed-off-by: Chang Xiangzhong <changxiangzhong@gmail.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/associola.c