]> git.openfabrics.org - ~emulex/infiniband.git/commit
btrfs: restrict snapshotting to own subvolumes
authorDavid Sterba <dsterba@suse.cz>
Wed, 15 Jan 2014 17:15:52 +0000 (18:15 +0100)
committerChris Mason <clm@fb.com>
Tue, 28 Jan 2014 21:20:40 +0000 (13:20 -0800)
commitd024206133ce21936b3d5780359afc00247655b7
treea1385db3cea4ec6cc90b6b5e91c05d0877c95f62
parent89d4346a36a00ab1f9bd71f929564e9fc1c7c539
btrfs: restrict snapshotting to own subvolumes

Currently, any user can snapshot any subvolume if the path is accessible and
thus indirectly create and keep files he does not own under his direcotries.
This is not possible with traditional directories.

In security context, a user can snapshot root filesystem and pin any
potentially buggy binaries, even if the updates are applied.

All the snapshots are visible to the administrator, so it's possible to
verify if there are suspicious snapshots.

Another more practical problem is that any user can pin the space used
by eg. root and cause ENOSPC.

Original report:
https://bugs.launchpad.net/ubuntu/+source/apparmor/+bug/484786

CC: stable@vger.kernel.org
Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: Chris Mason <clm@fb.com>
fs/btrfs/ioctl.c