]> git.openfabrics.org - ~shefty/rdma-dev.git/commit
[media] ds3000: remove useless 'locking'
authorRémi Cardona <remi.cardona@smartjog.com>
Fri, 28 Sep 2012 11:59:27 +0000 (08:59 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 22 Nov 2012 21:19:00 +0000 (19:19 -0200)
commitb41a536cf9806c3478b2fa68d59edafd0787e8aa
treed16084be3536e3059ae30496df1486747e683b77
parentfeadd7d3eca4da531b35b2af3623dd992f2d988d
[media] ds3000: remove useless 'locking'

Since b9bf2eafaad9c1ef02fb3db38c74568be601a43a, the function
ds3000_firmware_ondemand() is called only once during init. This
locking scheme may have been useful when the firmware was loaded at
each tune.
Furthermore, it looks like this 'lock' was put in to prevent concurrent
access (and not recursion as the comments suggest). However, this open-
coded mechanism is anything but race-free and should have used a proper
mutex.

Signed-off-by: Rémi Cardona <remi.cardona@smartjog.com>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb-frontends/ds3000.c