]> git.openfabrics.org - ~emulex/infiniband.git/commit
s390/oprofile: make return of 0 explicit
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 19 May 2014 04:31:15 +0000 (06:31 +0200)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Tue, 27 May 2014 08:26:00 +0000 (10:26 +0200)
commit94414ca08afabbb5d19511ef57ec397a07fc6d35
tree8255acd9fdf438e4378c5fd0f6cc39f58acd9523
parent470ada6b1a1d80a173586c036f84e2c3a486ebf9
s390/oprofile: make return of 0 explicit

Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.

A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
local idexpression ret;
expression e;
position p;
@@

-ret = 0;
... when != ret = e
return
- ret
+ 0
  ;
// </smpl>

[heiko.carstens: turn prepare_cpu_buffers into a void returning function]
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
arch/s390/oprofile/hwsampler.c