]> git.openfabrics.org - ~shefty/rdma-dev.git/commit
PCI: Avoid potential NULL pointer dereference in pci_scan_bridge
authorJesper Juhl <jj@chaosbits.net>
Mon, 24 Jan 2011 20:14:33 +0000 (21:14 +0100)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Tue, 8 Feb 2011 21:08:05 +0000 (13:08 -0800)
commit7c867c8899e873652ef98a890d2e647c092bec25
tree482e3c673dd58243be6ed73915fd0c92dc44ca9a
parentc13ff2ff3ad1479f222e18f9caba3db5af68d549
PCI: Avoid potential NULL pointer dereference in pci_scan_bridge

pci_add_new_bus() calls pci_alloc_child_bus() which calls pci_alloc_bus()
that allocates memory dynamically with kzalloc(). The return value of
kzalloc() is the pointer that's eventually returned from
pci_add_new_bus(), so since kzalloc() can fail and return NULL so can
pci_add_new_bus(). Thus we may end up dereferencing a NULL pointer in
drivers/pci/probe.c::pci_scan_bridge(). Seems to me we should test for
this and bail out if it happens rather than crashing.
Also removed some trailing whitespace that bugged me while looking at
this.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
drivers/pci/probe.c