]> git.openfabrics.org - ~emulex/infiniband.git/commit
mmc: tmio: Don't access hardware registers after stopping clocks
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tue, 12 Jun 2012 21:29:35 +0000 (23:29 +0200)
committerChris Ball <cjb@laptop.org>
Sat, 21 Jul 2012 04:02:07 +0000 (00:02 -0400)
commit6de707f200f73af7a58b58b3a5b956cff7b6e228
tree6b4c98cbf5720e2acd5e2cd0958043434aa000ea
parent7541ca98477862e2e9988c6c2ceadbdccefa9d77
mmc: tmio: Don't access hardware registers after stopping clocks

The tmio_mmc_set_ios() function configures the MMC power, clock and bus
width. When the mmc core requests the driver to power off the card, we
inform runtime PM, that the controller can be suspended. This can lead
to the MSTP clock being turned off.

Writing to any 16-bit hardware registers with the MSTP clock off leads
to timeouts and errors being printed to the kernel log. This can occur
both when stopping the MMC clock and when configuring the bus width.

To fix this, stop the MMC clock before calling put_runtime_pm(), and
skip bus width configuration when power is off.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Simon Horman <horms@verge.net.au>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Chris Ball <cjb@laptop.org>
drivers/mmc/host/tmio_mmc_pio.c