]> git.openfabrics.org - ~emulex/infiniband.git/commit
drm/i915: Fix erroneous conversion to u8
authorDamien Lespiau <damien.lespiau@intel.com>
Fri, 8 Aug 2014 18:25:57 +0000 (19:25 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 8 Aug 2014 18:52:31 +0000 (20:52 +0200)
commit4fa790421c10e5c9c62406655c06d97a94555d54
treec07935a465bdcc7a37093a8b02fb20046d183a34
parent2c0827cffca8ac0c654b888c58a1989a5172f007
drm/i915: Fix erroneous conversion to u8

adj was defined as u8. The issue is last_adj can be negative and adj is
initialized with:

  adj = dev_priv->rps.last_adj;

and we were also happily doing things like:

  if (adj < 0)

(thank static analysers!)

v2: Make new_delay an int in case we overflow the u8 in the intermediate
    computations. new_delay will get clamped at the end anyway. (Ville)

Cc: Deepak S <deepak.s@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_irq.c