]> git.openfabrics.org - ~emulex/infiniband.git/commit
[SCSI] libsas: introduce scmd_dbg() to quiet false positive "timeout" messages
authorDan Williams <dan.j.williams@intel.com>
Thu, 6 Feb 2014 20:23:07 +0000 (12:23 -0800)
committerJames Bottomley <JBottomley@Parallels.com>
Sat, 15 Mar 2014 17:18:53 +0000 (10:18 -0700)
commit3af74a3c07d93e34fce3d6c6dcd73676d8381d21
tree5dcda82fb9fec85c5f25b7b7c418f735b219104b
parent4440e46d5db7b445a961a84444849b2a31fa7fd1
[SCSI] libsas: introduce scmd_dbg() to quiet false positive "timeout" messages

libsas sometimes short circuits timeouts to force commands into error
recovery.  It is misleading to log that the command timed-out in
sas_scsi_timed_out() when in fact it was just queued for error handling.
It's also redundant in the case of a true timeout as libata eh will
detect and report timeouts via it's AC_ERR_TIMEOUT facility.

Given that some environments consider "timeout" errors to be indicative
of impending device failure demote the sas_scsi_timed_out() timeout
message to be disabled by default.  This parallels ata_scsi_timed_out().

[jejb: checkpatch fix]
Reported-by: Xun Ni <xun.ni@intel.com>
Tested-by: Nelson Cheng <nelson.cheng@intel.com>
Acked-by: Lukasz Dorau <lukasz.dorau@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/libsas/sas_scsi_host.c
include/scsi/scsi_device.h