]> git.openfabrics.org - ~emulex/infiniband.git/commit
teaming: fix vlan_features computing
authorMichal Kubeček <mkubecek@suse.cz>
Tue, 20 May 2014 06:29:45 +0000 (08:29 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 May 2014 19:07:23 +0000 (15:07 -0400)
commit3625920b62c32041f796f0ca14da84731de40d57
tree6eff4a2f3320213c451d73a24eda76083628e01c
parenta9b3ace44c7d4eb021a78a4d2e6bb812c34f086f
teaming: fix vlan_features computing

__team_compute_features() uses netdev_increment_features() to
combine vlan_features of slaves into vlan_features of the team.
As netdev_increment_features() only adds most features and we
start with TEAM_VLAN_FEATURES, we can end up with features none
of the slaves provided.

Initialize vlan_features only with the flags which are both in
TEAM_VLAN_FEATURES and NETIF_F_ALL_FOR_ALL. Right now there is
no such feature so that we actually initialize vlan_features
with zero but stating it explicitely will make the code more
future proof.

Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/team/team.c