]> git.openfabrics.org - ~emulex/infiniband.git/commit
staging: brcm80211: bugfix for len==0 parameter in 3 fullmac functions
authorRoland Vossen <rvossen@broadcom.com>
Mon, 8 Aug 2011 13:57:46 +0000 (15:57 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 23 Aug 2011 19:59:50 +0000 (12:59 -0700)
commit2c1599cfd6a736e09c29c772fbaf41250646ad42
tree0e2f0069a6e5112822c992147c86f81fb65593e8
parenta9f81a9378d634ad693527939e0e8bfd0665c648
staging: brcm80211: bugfix for len==0 parameter in 3 fullmac functions

Three functions use the same method to check incoming parameters. The
'len' parameter can be equal to 0 in case of a 'set' operation.
Currently these functions return an error code under that condition,
which is incorrect. The problem was introduced in recent patches in
which asserts were removed from the fullmac.

Despite this being a bug, my regression testing has not shown any problems.

Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/brcm80211/brcmfmac/bcmsdh_sdmmc.c
drivers/staging/brcm80211/brcmfmac/dhd_common.c
drivers/staging/brcm80211/brcmfmac/dhd_sdio.c