]> git.openfabrics.org - ~emulex/infiniband.git/commit
drivers/net/wireless/libertas: Adjust confusing if indentation
authorJulia Lawall <julia@diku.dk>
Thu, 5 Aug 2010 20:23:54 +0000 (22:23 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 16 Aug 2010 19:26:41 +0000 (15:26 -0400)
commit2674f82d3eef97df98fd5dbd4224ce1ce4800a3b
treed79d639bd6fc730523e5ed9aa725e0aadc0235d4
parent04600794958f1833f5571c6cde40f260ab557f55
drivers/net/wireless/libertas: Adjust confusing if indentation

At the point of the patched code, err has already been tested, so it is
only worthwhile to test it again in the if branches where it is changed.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@

(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

if (p1[0].column == p2[0].column):
  cocci.print_main("branch",p1)
  cocci.print_secs("after",p2)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/libertas/if_spi.c