]> git.openfabrics.org - ~emulex/infiniband.git/commit
blkcg: fix error return path in blkg_create()
authorTejun Heo <tj@kernel.org>
Tue, 14 May 2013 20:52:30 +0000 (13:52 -0700)
committerTejun Heo <tj@kernel.org>
Tue, 14 May 2013 20:52:30 +0000 (13:52 -0700)
commit2423c9c3f0ffffa8f87cbdafe9781273c5d1b6a2
tree6ddb6e8f4cd577adab194c90eccec5ad50f2ab08
parentf722406faae2d073cc1d01063d1123c35425939e
blkcg: fix error return path in blkg_create()

In blkg_create(), after lookup of parent fails, the control jumps to
error path with the error code encoded into @blkg.  The error path
doesn't use @blkg for the return value.  It returns ERR_PTR(ret).
Make lookup fail path set @ret instead of @blkg.

Note that the parent lookup is guaranteed to succeed at that point and
the condition check is purely for sanity and triggers WARN when fails.
As such, I don't think it's necessary to mark it for -stable.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
block/blk-cgroup.c