]> git.openfabrics.org - ~shefty/rdma-dev.git/commit
rtc: rp5c01: Initialize drvdata before registering device
authorJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 00:31:20 +0000 (17:31 -0700)
committerJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 01:02:05 +0000 (18:02 -0700)
commit130107b270f9a8ef1b50e02140a381c44a6abd68
treed2290f18d668d1baa6d55f82503cd9c96181cb1e
parent4b3687f9c18156cdb71729fe4e0c3000f7e4d7de
rtc: rp5c01: Initialize drvdata before registering device

Commit f44f7f96a20 ("RTC: Initialize kernel state from RTC") uncovered
an issue in a number of RTC drivers, where the drivers call
rtc_device_register before initializing the device or platform drvdata.

This frequently results in null pointer dereferences when the
rtc_device_register immediately makes use of the rtc device, calling
rtc_read_alarm.

The solution is to ensure the drvdata is initialized prior to registering
the rtc device.

CC: Wolfram Sang <w.sang@pengutronix.de>
CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: rtc-linux@googlegroups.com
Signed-off-by: John Stultz <john.stultz@linaro.org>
drivers/rtc/rtc-rp5c01.c