]> git.openfabrics.org - ~shefty/rdma-dev.git/commit
ath_hw: Use common REG_WRITE parameter order
authorSven Eckelmann <sven@narfation.org>
Thu, 4 Oct 2012 17:43:15 +0000 (19:43 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 19 Oct 2012 19:53:06 +0000 (15:53 -0400)
commit037fd9b6473393c35a31f0c43e26eb7e874e901d
tree36952e61f40c5ab8975c1e2df522aae477a3b168
parented9f0ed3b977f480a35ea3d3e9d966d89724185e
ath_hw: Use common REG_WRITE parameter order

All defines for REG_WRITE in Atheros wireless drivers use the order "ah",
"register" and "value". hw.c is the only file using the order "ah", "value" and
"register".

drivers/net/wireless/ath/ath9k/hw.h:#define REG_WRITE(_ah, _reg, _val) \
drivers/net/wireless/ath/key.c:#define REG_WRITE(_ah, _reg, _val) (common->ops->write)(_ah, _val, _reg)

This inconsistent definition can easily lead to implementation errors. The
modification doesn't change the behavior of the driver or the generated code.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Acked-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/hw.c